Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(simple_planning_simulator): rework parameters #5446

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+242 −70

style(pre-commit): autofix

323d1e0
Select commit
Loading
Failed to load commit list.
Open

refactor(simple_planning_simulator): rework parameters #5446

style(pre-commit): autofix
323d1e0
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 21, 2025 in 59s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.02 (7.52 -> 7.50)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method simple_planning_simulator.launch.py: launch_setup

Annotations

Check notice on line 90 in simulator/simple_planning_simulator/launch/simple_planning_simulator.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method 

launch_setup decreases from 91 to 85 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis