feat(lane_change_module): add update paramter function for non defined paramters #9887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the original implementation, while some parameters could be updated through
ros2 param set
and affected the behavior, other parameters did not influence the behavior despite being updated.However, since both the output and
ros2 param dump
results showed the changes, developers might have believed they had modified parameters when in fact the changes weren't affecting the system. This could cause issues during parameter tuning.To address this, I've modified the implementation to ensure all parameters can affect the behavior through the updateParam function, making the runtime parameter updates consistent and effective.
I removed the intermediate variables since they appeared redundant, but I don't fully understand why they were implemented in the original code.
If these intermediate variables served a specific purpose (e.g., validation, safety checks, or compatibility), I will revert these changes.
How was this PR tested?
set paramter with following command with attached script
set_lane_change_param.zip
And got following output
output
run planning simulator and lane_change module executed.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.