Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change_module): add update paramter function for non defined paramters #9887

feat(lane_change): update parameter handling and add lateral accelera…

83b1329
Select commit
Loading
Failed to load commit list.
Merged

feat(lane_change_module): add update paramter function for non defined paramters #9887

feat(lane_change): update parameter handling and add lateral accelera…
83b1329
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 14, 2025 in 50s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.66 (7.58 -> 6.91)

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method manager.cpp: LaneChangeModuleManager::updateModuleParams
  • Complex Conditional manager.cpp: LaneChangeModuleManager::updateModuleParams

✅ Improving Code Health:

  • Large Method manager.cpp: LaneChangeModuleManager::updateModuleParams

Annotations

Check warning on line 552 in planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

LaneChangeModuleManager::updateModuleParams has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 404 in planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

LaneChangeModuleManager::updateModuleParams has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check notice on line 552 in planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Large Method

LaneChangeModuleManager::updateModuleParams is no longer above the threshold for lines of code