-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(irq): prevent interrupt reservation and improve error handling #97
Conversation
@josecm consolidated all error message updates into a single commit (878ad2b). As this commit fixes the content introduced in 5887601, may I squash both commits to keep the git history clean? The same applies to commits 1a898b4 and 196a404 ( The first one introduces the spinlock initialization). Should they be squashed? |
@Diogo21Costa Yeah, I'd say the history should be re-written and include the new fixes directly on the original commits. |
878ad2b
to
5840a65
Compare
@josecm Done, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit's description df3168c does not match the code changes
Otherwise seems good
bf3e598
to
c27d8fa
Compare
@DavidMCerdeira Nice catch, thank you. Solved. |
c27d8fa
to
05a570f
Compare
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
05a570f
to
ae4badd
Compare
PR Description
This PR enhances the interrupt reservation functions to prevent race conditions during the reservation process. It comprises the following changes:
Your feedback on these changes is greatly appreciated.