Minor docs fixes #16347
Merged
Minor docs fixes #16347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richchurcher
added
C-Docs
BenjaminBrienen
approved these changes
Nov 11, 2024
mnmaita
approved these changes
Nov 12, 2024
mnmaita
added
S-Ready-For-Final-Review
mockersf
reviewed
Nov 12, 2024
crates/bevy_picking/src/backend.rs
Outdated
| //! physics objects, a picking shader backend to pick non-physics meshes, and the `bevy_ui` backend | ||
| //! for your UI. The [`PointerHits`]s produced by these various backends will be combined, sorted, | ||
| //! for your UI. The [`PointerHits`] produced by these various backends will be combined, sorted, |
There was a problem hiding this comment.
Suggested change
| //! for your UI. The [`PointerHits`] produced by these various backends will be combined, sorted, | |
| //! for your UI. The [`PointerHits`] events produced by these various backends will be combined, sorted, |
PointerHits is the individual thing that is produced, so that "double plural" is somewhat correct here
There was a problem hiding this comment.
Yeah, it did occur to me... 🤔 what about
The [
PointerHits] instances produced...
to avoid the double 's'? Otherwise I don't feel strongly.
BenjaminBrienen
added
S-Waiting-on-Author
richchurcher
added
S-Ready-For-Final-Review
mockersf
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened upon a few stray characters while reading about picking.