Skip to content

Remove YAxisOrientation from bevy_text #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove YAxisOrientation from bevy_text #19077

wants to merge 3 commits into from
+7 −26

Conversation

ickshonpe
Copy link
Contributor

Objective

Been looking for simplifications in the text systems as part of the text input changes.

This enum isn't very helpful I think. We can remove it and the associated parameters and instead just negate the glyph's y-offsets in extract_text2d_sprite.

Solution

Remove the YAxisOrientation enum and parameters.
Queue text sprites relative to the top-left in extract_text2d_sprite and negate the glyph's y-offset.

Testing

The text2d example can be used for testing:

cargo run --example text2d

ickshonpe added 3 commits May 5, 2025 16:58
@ickshonpe
Removed the YAxisOrientation enum.
7f95169 
In `extract_text2d_sprite` use coords relative to the top left corner and reverse y-axis.
@ickshonpe
construct new offset vec with negative y instead of multiplying.
ef0c5e6
@ickshonpe
Fixed anchor translation
6457fc5
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Rendering Drawing game state to the screen and removed A-UI Graphical user interfaces, styles, layouts, and widgets labels May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @alice-i-cecile