Fix a NestedLoader
code path that failed to use its meta transform
#19117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
While poking around
NestedLoader
I happened to notice that one code path failed to pass on the loader's meta transform.This seems like a simple oversight - everything else that can pass on the meta transform does so - although I'm not familiar enough with the asset system to be 100% sure. It was introduced when asset loaders were changed to use the builder pattern (#13465).
Unfortunately I couldn't find a case that actually hits this code path. So I don't have a good test case, and I don't know if any users have experienced it as a bug.
Testing
Also tested various examples -
testbed_2d
,testbed_3d
and everything inexamples/asset
.