Skip to content

Conversation

@greeble-dev
Copy link
Contributor

@greeble-dev greeble-dev commented May 7, 2025

Solution

While poking around NestedLoader I noticed that one code path fails to pass on the loader's meta transform.

- .get_or_create_path_handle(path, None)
+ .get_or_create_path_handle(path, self.meta_transform)

This seems like a simple oversight - all other code paths pass on the meta transform where possible - although I'm not familiar enough with the asset system to be 100% sure. It was introduced when asset loaders were changed to use the builder pattern (#13465).

Unfortunately I couldn't find an example that actually hits this code path. So I don't have a good test case, and I don't know if any users have experienced it as a bug.

Testing

cargo test -p bevy_asset

Also tested various examples - testbed_2d, testbed_3d and everything in examples/asset.

@greeble-dev greeble-dev added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 7, 2025
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 9, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 14, 2025
Merged via the queue into bevyengine:main with commit 87db376 Jul 14, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants