-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding context menu example #19245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding context menu example #19245
Conversation
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'm approving if the CI goes green ; this PR is conflicting with New cooldown example #19234 and the other PRs adding the new
usage
folder.
@Vrixyz added a bunch more docs and cleanups. happy to hear what you think |
I like this example, other than a small nit on docs which may not be blocking, I added a comment on there which may be important to make sure we understand what this example does: https://github.com/bevyengine/bevy/pull/19245/files/eda7098b2b4e9a281253705b458cab263420fc57#r2094492441 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but I like this example!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to have the context menu only appear when Mouse2 (or secondary pointer input button) is pressed, as that is more common.
@BenjaminBrienen I would love to not do that for two reasons:
|
I don't think floating context menus are the appropriate way of getting input from touchscreen users, but I think your points are very valid. |
This is probably going to get merge conflicts, but I'll try merging and see if anything breaks <3 |
Has merge conflicts 😋 |
@BenjaminBrienen Ahh the new BorderColor's - should be fixed now |
Co-authored-by: Rob Parrett <[email protected]>
Objective
Provides usage example of a context menu
Testing
Showcase
Screenflick.Movie.120.mp4