Camera composition #19706
Closed
Camera composition #19706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will be relevant in later prs, but handled by a different struct
alice-i-cecile
added
A-Rendering
everything is broken oh god WIP WIP WIP WIP
WIP WIP fix errors most are dummy fixes, just so I could get IDE messages out of my way comments and todos abound, will be fixed next :) WIP WIP WIP WIP WIP WIP add todo msg WIP WIP update comment
ecoskey
force-pushed
the
camera_composition
branch
from
f2c6ca7 to
0139c77
Compare
|
closing, I don't think this current iteration will get to a state worth merging and was mostly for discussion visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up for discussion's sake
am too lazy to write a description rn.