Skip to content

Split Bundle and StaticBundle #19761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

SkiFire13
Copy link
Contributor

Objective

Solution

  • Create a new StaticBundle type, mirroring Bundle for now
  • Switch all APIs that need to statically know the components in a Bundle (i.e. from its type) to use StaticBundle
  • Add &self parameters to Bundle to ensure all APIs that use it have a concrete instance to work with in the future.

Additional notes

For now this doesn't do anything functionally, as Bundle still requires the components to be statically fixed. However this opens the doors for changes to the Bundle trait that allow dynamic components without impacting APIs that actually rely on static components.

Copy link
Contributor

@ElliottjPierce ElliottjPierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The parallel contents of code for StaticBundle vs Bundle is kinda annoying, but I know that's changing in the next prs, so I'm not worried about it.

@ElliottjPierce ElliottjPierce added A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants