-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Split Bundle
and StaticBundle
#19761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SkiFire13
wants to merge
18
commits into
bevyengine:main
Choose a base branch
from
SkiFire13:split-bundle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+585
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliottjPierce
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The parallel contents of code for StaticBundle
vs Bundle
is kinda annoying, but I know that's changing in the next prs, so I'm not worried about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Option
bundles andBox<dyn Bundle>
#19491Bundle
into one type representing a static set of component types (StaticBundle
) and one that will be used for representing a possibly dynamic set of components.Solution
StaticBundle
type, mirroringBundle
for nowBundle
(i.e. from its type) to useStaticBundle
&self
parameters toBundle
to ensure all APIs that use it have a concrete instance to work with in the future.Additional notes
For now this doesn't do anything functionally, as
Bundle
still requires the components to be statically fixed. However this opens the doors for changes to theBundle
trait that allow dynamic components without impacting APIs that actually rely on static components.