-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Rework required components #20110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rework required components #20110
Conversation
5362a26
to
8b14b9c
Compare
8b14b9c
to
18c4ca4
Compare
@SkiFire13 is this ready for review now that the bundle-split PR is merged? This is still in draft mode :) |
Ah yes, I was forgetting to change the status! I think it might still need some more tests, but the implementation should be ready. |
I encountered an issue where a required component is not registered at all on I try to review this the next days and if needed suggest another test if this is missing. |
Objective
RequiredComponent.inheritance_depth
docs do not matchComponent
derive impl #19863 by removinginheritance_depth
Solution
Testing
TODO
Showcase
TODO