Skip to content

Rework required components #20110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SkiFire13
Copy link
Contributor

@SkiFire13 SkiFire13 commented Jul 13, 2025

Objective

Solution

Testing

TODO

Showcase

TODO

@SkiFire13 SkiFire13 force-pushed the rework-required-components branch 2 times, most recently from 5362a26 to 8b14b9c Compare July 13, 2025 14:48
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Blocked This cannot move forward until something else changes C-Bug An unexpected or incorrect behavior X-Contentious There are nontrivial implications that should be thought through labels Jul 14, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jul 14, 2025
@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Blocked This cannot move forward until something else changes labels Jul 14, 2025
@SkiFire13 SkiFire13 force-pushed the rework-required-components branch from 8b14b9c to 18c4ca4 Compare July 14, 2025 18:39
@alice-i-cecile
Copy link
Member

@SkiFire13 is this ready for review now that the bundle-split PR is merged? This is still in draft mode :)

@alice-i-cecile alice-i-cecile requested review from cart and Jondolf July 14, 2025 19:33
@SkiFire13 SkiFire13 marked this pull request as ready for review July 14, 2025 19:48
@SkiFire13
Copy link
Contributor Author

SkiFire13 commented Jul 14, 2025

@SkiFire13 is this ready for review now that the bundle-split PR is merged? This is still in draft mode :)

Ah yes, I was forgetting to change the status! I think it might still need some more tests, but the implementation should be ready.

@urben1680
Copy link
Contributor

I encountered an issue where a required component is not registered at all on main during my work on #19852. This PR seems to fix that too. That problem seems to be not among the issues listed here.

I try to review this the next days and if needed suggest another test if this is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequiredComponent.inheritance_depth docs do not matchComponent derive impl Inconsistent Behavior with Required Components
3 participants