Skip to content

Documentation mentionting chained .run_if(a).run_if(b) does not short-circuit, in contrast to run_if(a.and(b)) #21710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Documentation mentionting chained .run_if(a).run_if(b) does not short-circuit, in contrast to run_if(a.and(b)) #21710

wants to merge 5 commits into from
+44 −2

Conversation

@ZackaryRippee
Copy link

@ZackaryRippee ZackaryRippee commented Nov 1, 2025

Objective

solving issue #21244

Solution

  • Adding the documentation

Testing

  • Double checked to make sure the scenario is true, and it holds

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 3, 2025
alice-i-cecile
alice-i-cecile requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mdlint is going to have words with you for your formatting, but I like the content for the most part.

The system_registry.rs changes look like they shouldn't be included in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZackaryRippee @alice-i-cecile @DylanD42