Skip to content

Deduplicate world_to_view logic #21715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Deduplicate world_to_view logic #21715

wants to merge 3 commits into from

Conversation

@Breakdown-Dog
Copy link
Contributor

@Breakdown-Dog Breakdown-Dog commented Nov 2, 2025

Objective

  • The functions logical_viewport_size and physical_viewport_size in camera.rs share a very similar pattern.
  • Refactor code to reduce duplication.

Solution

  • extract to a shared function.

Testing

  • Ran cargo test and all the tests pass.

@mnmaita mnmaita added C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Camera User-facing camera APIs and controllers. labels Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Camera User-facing camera APIs and controllers. C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Breakdown-Dog @mnmaita