Allow setting time overstep in tests #21738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 3, 2025
alice-i-cecile
added
D-Trivial
andrewhickman
commented
Nov 4, 2025
Comment on lines
+185
to
+191
| /// Increase the overstep time accumulated towards new steps. | ||
| /// | ||
| /// This method is provided for use in tests. Ordinarily, the [`run_fixed_main_schedule`] system is responsible for calculating the overstep. | ||
| #[inline] | ||
| pub fn accumulate_overstep(&mut self, delta: Duration) { | ||
| self.context_mut().overstep += delta; | ||
| } |
There was a problem hiding this comment.
This is intended for use in tests outside this crate, but AFAIK #[cfg(test)] only works for unit tests within the crate
dloukadakis
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is currently no way to construct a
Time<Fixed>with a non-zero overstep. The only way to test systems which use the overstep is to advance the virtual time and run theRunFixedMainLoopschedule, which is cumbersome.Solution
Exposes the
accumulate_overstepmethod as a counterpart ofdiscard_overstep.Testing
This method is covered by existing tests.