Linux refactor: Episode I #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
refactor_linux_part_1
branch
17 times, most recently
from
8564fd6
to
6054c63
Compare
Williangalvani
requested review from
patrickelectric,
joaoantoniocardoso and
JoaoMario109
and removed request for
patrickelectric
Williangalvani
force-pushed
the
refactor_linux_part_1
branch
from
6054c63
to
03aa660
Compare
patrickelectric
requested changes
Jun 12, 2024
| release = "Bullseye" | ||
| os_release = load_file("/etc/os-release") | ||
| if "bookworm" in os_release: | ||
| release = "Bookworm" |
There was a problem hiding this comment.
Can we use an enum here ?
There was a problem hiding this comment.
can this wait?
I plan to move the checks for os_release and pi version to commonwealth in the next PR
core/services/ardupilot_manager/flight_controller_detector/linux/navigator.py
Outdated
Show resolved
Hide resolved
core/services/ardupilot_manager/flight_controller_detector/linux/linux_boards.py
Outdated
Show resolved
Hide resolved
core/services/ardupilot_manager/flight_controller_detector/linux/linux_boards.py
Outdated
Show resolved
Hide resolved
|
Nice one, eager for the next episodes! |
Williangalvani
force-pushed
the
refactor_linux_part_1
branch
3 times, most recently
from
5ed424a
to
2805f3b
Compare
Williangalvani
force-pushed
the
refactor_linux_part_1
branch
from
2805f3b
to
c09b8a7
Compare
Yeah, might be a smarted move if this is not required for 1.3 |
patrickelectric
added
the
merge-after-stable
Yes, it is probably wiser to keep it for the next sable |
Williangalvani
force-pushed
the
refactor_linux_part_1
branch
from
c09b8a7
to
e597a2e
Compare
patrickelectric
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting it up to make the review process smoother
tested on pi4/bullseye
test on pi5/bookworm
port mapping on pi4/bullseye has changed =[updated serial mapping for pi4 on bullseye