Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for jsr repository #679

Merged
merged 54 commits into from
May 5, 2024
Merged

feat: add support for jsr repository #679

merged 54 commits into from
May 5, 2024

Conversation

JOTSR
Copy link
Contributor

@JOTSR JOTSR commented Feb 29, 2024

Summary

Add support for jsr repository.

Motivation

Allow use of cliffy in jsr packages.

Changes

  • Replace all remote url imports by jsr or npm imports.
  • Add package metadatas (name and version need to be approved/updated).
  • Fix all slow types.
  • Upgrade deno/std to 0.217.
  • Add jsr publish workflow

Copy link
Owner

@c4spar c4spar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @JOTSR for the MR! I left a view comments.

deno.jsonc Outdated Show resolved Hide resolved
ansi/ansi_escapes.ts Outdated Show resolved Hide resolved
ansi/deps.ts Outdated Show resolved Hide resolved
examples/ansi.ts Show resolved Hide resolved
deno.jsonc Outdated Show resolved Hide resolved
@JOTSR
Copy link
Contributor Author

JOTSR commented Mar 9, 2024

deno publish --dry-run failed to resolve types imported in @cliffy/command/type.ts. Maybe I can use a temp patch if the bug persist and is not resolved before PR merge. (reported on @denoland/deno#22819)

@JOTSR JOTSR marked this pull request as draft March 9, 2024 00:21
JOTSR and others added 3 commits March 14, 2024 00:33
Remove `examples` directory from workspace to disable `deno publish` for it.
@JOTSR
Copy link
Contributor Author

JOTSR commented Mar 14, 2024

Deno 1.41.3 was just released and fix denoland/deno#22819 so cliffy is now ready for jsr.
I made a last commit to run deno fmt and harmonize source code to continue from an fresh base.

@JOTSR JOTSR marked this pull request as ready for review March 14, 2024 21:36
command/_errors.ts Outdated Show resolved Hide resolved
@c4spar
Copy link
Owner

c4spar commented Mar 17, 2024

There seems to be an issue with the snapshotTest method. The "deno run" command, which is called in the snapshotTest method, does not automatically load the deno config from the current working directory and does not resolve the imports correctly. It only works if I explicitly add the config to the command.

ansi/deno.json Outdated Show resolved Hide resolved
Copy link
Owner

@c4spar c4spar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx again for your help @JOTSR! I think we can merge it now. I have add a workaround to get the tests working with the experimental workspace feature.

@c4spar c4spar merged commit ff14148 into c4spar:main May 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants