-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for jsr
repository
#679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @JOTSR for the MR! I left a view comments.
|
Co-authored-by: Benjamin Fischer <[email protected]>
Remove `examples` directory from workspace to disable `deno publish` for it.
Deno 1.41.3 was just released and fix denoland/deno#22819 so cliffy is now ready for |
There seems to be an issue with the snapshotTest method. The "deno run" command, which is called in the snapshotTest method, does not automatically load the deno config from the current working directory and does not resolve the imports correctly. It only works if I explicitly add the config to the command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx again for your help @JOTSR! I think we can merge it now. I have add a workaround to get the tests working with the experimental workspace feature.
Summary
Add support for jsr repository.
Motivation
Allow use of cliffy in jsr packages.
Changes
jsr
ornpm
imports.deno/std
to0.217
.jsr
publish workflow