Update atomic_trigger_conditions.py #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the StandStill() class, change the EPSILON, 0.001, to the float value 0.1. When a vehicle stops after cruising, even though it actually not moves at all, but the velocity could have a value larger than 0.001. The change makes StandStill() class work properly not only before vehicle's start but also after the vehicle's stop. In the StandStill() class, change the EPSILON, 0.001, to the float value 0.1. When a vehicle stops after cruising, even though it actually not moves at all, but the velocity could have a value larger than 0.001. The change makes StandStill() class work properly not only before vehicle's start but also after the vehicle's stop.
glopezdiest
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TigerStone93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
StandStillclass, change theEPSILON,0.001, to the float value0.1.When a vehicle stops after cruising, even though it actually not moves at all, but the
velocitycould have a value larger than0.001while the displayed velocity is 0kph, so theStandStillConditionis not triggered as the developer's original intention.This change makes
StandStillclass work properly not only before vehicle's start but also after the vehicle's stop.Where has this been tested?
This change is