Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing breaks from the schedule #438

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Removing breaks from the schedule #438

merged 6 commits into from
Oct 29, 2024

Conversation

anenadic
Copy link
Collaborator

Fixes #396.

Would be good to have a second eye on the proposed schedule in instructor notes - e.g. @sstevens2 from her fresh memory of the workshop this week.

Copy link

github-actions bot commented Oct 25, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-438

The following changes were observed in the rendered markdown documents:

 config.yaml            |  7 ----
 instructor-notes.md    | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++
 long-break1.md (gone)  | 12 -------
 long-break2.md (gone)  | 12 -------
 long-break3.md (gone)  | 12 -------
 md5sum.txt             | 13 ++------
 short-break1.md (gone) | 12 -------
 short-break2.md (gone) | 12 -------
 short-break4.md (gone) | 12 -------
 short-break6.md (gone) | 12 -------
 wrap-up1.md            |  2 +-
 11 files changed, 94 insertions(+), 102 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-29 08:32:55 +0000

github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
Copy link
Collaborator

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember when we took our breaks in the recent one. I tried to do them 1.35 hrs in and then 2.75 hrs in approximately.

My in-line comments mostly make the formatting consistent when a break splits the content of an episode into two sections.

instructors/instructor-notes.md Outdated Show resolved Hide resolved
instructors/instructor-notes.md Outdated Show resolved Hide resolved
instructors/instructor-notes.md Outdated Show resolved Hide resolved
instructors/instructor-notes.md Outdated Show resolved Hide resolved
instructors/instructor-notes.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
@anenadic anenadic merged commit fadae9f into main Oct 29, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : fadae9f
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2024-10-29 08:33:57 +0000
Message : Merge pull request #438 from carpentries/issue-396

Removing breaks from the schedule
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 65842ec
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-29 08:34:40 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : fadae9f
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2024-10-29 08:33:57 +0000
Message : Merge pull request #438 from carpentries/issue-396

Removing breaks from the schedule
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : 65842ec
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-29 08:34:40 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : fadae9f
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2024-10-29 08:33:57 +0000
Message : Merge pull request #438 from carpentries/issue-396

Removing breaks from the schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Break episodes?
2 participants