Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Varadero revamp #3676

Merged
merged 23 commits into from
Jul 19, 2023
Merged

New Varadero revamp #3676

merged 23 commits into from
Jul 19, 2023

Conversation

AnuvKH
Copy link
Contributor

@AnuvKH AnuvKH commented Jun 19, 2023

About the pull request

Current revamp of New Varadero with a number of additions, balance changes, and adjustments/removals to address previous problems. Tested for DS and seems to work fine. Most changes were just to map assets with some minor additions/removals to code.

Explain why it's good for the game

New Varadero is a really cool and unique map with a refreshing break from the darker and more inhospitable colonies currently available. A lot of the gripes that caused it to be removed are straightforward and readily adjusted/changed here. Hopefully this will help increase map diversity and add another map choice to the current pool.

Testing Photographs and Procedure

Screenshots & Videos

Current SDMM:
https://cdn.discordapp.com/attachments/1119410465181814844/1120218810750861392/2023-06-18_22.08.47.png

Current Tacmap:
https://cdn.discordapp.com/attachments/1119410465181814844/1120218689673900162/webmap.png

Changelog

🆑 Anuv
fixes: #3775
add: Added a new storm siren unique to NV, new survivor types
spellcheck: Updates to the waking distress call notif.
code: Weather-related code changes. Update to the handheld maps.
soundadd: Added new monsoon weather sfx, new map-unique ambience, new storm siren sfx.
maptweak: New LZ (LZ2 Palm Airfield) in the NE with a construction zone. Removed a number of rocks around cave areas. Increased hive location choices from 3 to 4. Added glass ceilings to facility areas (deep caves are still protected, can be OB'd). Slightly widened the 45 minute weed protection areas around LZs. Added a fog monsoon to the SE beach that dissipates after an hour. Expanded east beach. New SW cave section. Opened up the walkway west of LZ1. Enhanced survivor loot and mats to a comparable degree to current maps. Many small changes to lessen chokes and offer more route choice for xenos and marines alike. Removed Spearhead/Rival and laser pistols. Swapped fawras for monkeys. Added more survivor-type choices. Added a bar area and decrepit truck to the north beach.
config: Enabled NV again as a map in maps.txt.
/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 19, 2023
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Code Improvement Make the code longer Config drag and drop labels Jun 19, 2023
@AnuvKH AnuvKH marked this pull request as ready for review June 21, 2023 21:50
@AnuvKH AnuvKH requested a review from morrowwolf as a code owner June 21, 2023 21:50
@AnuvKH
Copy link
Contributor Author

AnuvKH commented Jun 21, 2023

I'm not sure why the colonialmarines.test.dme file is so big, not sure if it's needed or not ahh

@AnuvKH AnuvKH changed the title New Varadero revamp (draft) New Varadero revamp Jun 23, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise the code looks fine

colonialmarines.test.dme Outdated Show resolved Hide resolved
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jun 23, 2023
@AnuvKH AnuvKH requested a review from harryob June 23, 2023 23:49
@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 126ef45 Jul 19, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

cm13-github added a commit that referenced this pull request Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Config drag and drop Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Mapping did you remember to save in tgm format? Needs Testing Need to test it on the guinea pigs (production server) Sound Blast 5 minutes of bass boosted music to our players Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookcase Inconsistency On New Veradero
5 participants