Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioscan Logging & Efficiency Upgrades #3755

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jun 28, 2023

About the pull request

Logs bioscans so I can ensure they're operating properly. This may not need to be full merged, but it won't hurt to do so.
Also improves efficiency of the code.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
admin: Adds logs for bioscans successfully completing.
/:cl:

@realforest2001 realforest2001 added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jun 28, 2023
@github-actions github-actions bot added the Admin Make things harder for admins label Jun 28, 2023
code/game/bioscans.dm Outdated Show resolved Hide resolved
code/game/bioscans.dm Outdated Show resolved Hide resolved
@realforest2001 realforest2001 changed the title Bioscan Logging Bioscan Logging & Efficiency Upgrades Jun 28, 2023
code/game/bioscans.dm Outdated Show resolved Hide resolved
code/game/bioscans.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working, though a forced xeno bioscan does not send anything to deadchat.
image

You likely want to use xeno_announcement instead of to_chat for xenos. You likely just want to add a loop to_chat to observers like the other scans. (But at the same time might not be necessary since they get the other two and it could be spammy - if so disregard).

The autoscans will appear like the following (though I couldn't find the stui log for the autoscan for the above image so maybe STUI was just out of date for the last message):
image

@Drulikar Drulikar linked an issue Jun 29, 2023 that may be closed by this pull request
3 tasks
code/game/bioscans.dm Outdated Show resolved Hide resolved
code/game/bioscans.dm Outdated Show resolved Hide resolved
@mrturkeytoe
Copy link

Hope I am not speaking out of turn or what not but,
have you considered pushing bioscan info to users in the lobby to help them judge how much time is left in the round?

At the moment they can already extrapolate it by looking at the round time, who is active/inactive on the crew manifest, how many xeno leaders there are, if they are T3, and if the queen is elder so just pushing the same bioscan info you do to dchat to the lobby as well would only make it easier to put that same information together to get an idea of if you want to join or wait.

code/game/bioscans.dm Outdated Show resolved Hide resolved
code/game/bioscans.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 5, 2023
Merged via the queue into cmss13-devs:master with commit 40a96c2 Jul 5, 2023
cm13-github added a commit that referenced this pull request Jul 5, 2023
github-actions bot added a commit that referenced this pull request Jul 5, 2023
@realforest2001 realforest2001 deleted the forest/bioscan branch July 10, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bioscans create no Debug or Admin logs
5 participants