Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CAS Weapon: BLU-200 Dragons Breath, thermobaric bomb #3832

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Jul 7, 2023

About the pull request

Adds a crowd control option to CAS missile options, to help incentivize people away from CAS Metabuilds.

  • Fire equivalent of the Banshee but without the impact damage.
  • Implosion from fuel-air bomb pulls nearby units towards the center.
  • 500 points (Expensive)

Explain why it's good for the game

Missiles on CAS are super expensive and rarely make their points back. In order to give the missile rack some punch and give it capabilities the other higher damage weapons dont have, we give it a bit of CC.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added new CAS Missile: BLU-200 Dragons Breath
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 7, 2023
@fira
Copy link
Member

fira commented Jul 7, 2023

This is potentially problematic in FM mode pulling into minirockets - and I don't really see the point of this as a direct-only weapon

@MemesLauncher
Copy link

Seems fun and fresh for jtac FM. Wonder how it would interact if two were to land at the same time on opposite direction

@Hopekz
Copy link
Contributor

Hopekz commented Jul 7, 2023

This is potentially problematic in FM mode pulling into minirockets - and I don't really see the point of this as a direct-only weapon

It's 500 CAS credit to fire once let people have fun for about 3-4 CAS runs before they go broke similar to how the 4x Gau build can only do a few runs before they're Perma broke

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 15, 2023
@morrowwolf morrowwolf added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 19, 2023
@morrowwolf
Copy link
Member

Questionable but let's give it a try at least

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 20, 2023
@morrowwolf
Copy link
Member

This hasn't been nearly as strong in reality as it seemed on paper. More options are good. Will tune more if required.


/obj/structure/ship_ammo/rocket/thermobaric/detonate_on(turf/impact)
impact.ceiling_debris_check(3)
fire_spread(impact, create_cause_data(initial(name), source_mob), 4, 25, 50, "#c96500") //Very intense but the fire doesn't last very long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using the timers like the others

@morrowwolf morrowwolf marked this pull request as draft July 21, 2023 18:15
Adding timer to fire, also reducing point cost as per player feedback
@blackdragonTOW
Copy link
Contributor Author

timer added to fire impact, reduced cost to put it in line with other CAS missiles aligning with player feedback.

@blackdragonTOW blackdragonTOW marked this pull request as ready for review July 21, 2023 18:34
@morrowwolf morrowwolf added this pull request to the merge queue Jul 22, 2023
Merged via the queue into cmss13-devs:master with commit 2ed3c42 Jul 22, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

cm13-github added a commit that referenced this pull request Jul 22, 2023
github-actions bot added a commit that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants