Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You now lose hiding when melee attacking #3902

Merged
merged 12 commits into from
Jul 24, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jul 15, 2023

About the pull request

Hiding now has 0.5 second cooldown, if you melee attack it will be 2 second cooldown and you lose hiding.

Explain why it's good for the game

For melee users, having to try to hit a target that is hiding can be an exercise in futility, with many aspects such as hitbox, placing weapon on table by mistake, and other factors, leading to a overall unfair advantage. (Other abilities unaffected.)

Testing Photographs and Procedure

Screenshots & Videos
Hide_post_attack.mp4

Changelog

🆑
balance: Xenomorphs lose their hiding ability for 2 seconds after a melee attack. 0.5 second cooldown applied to hide ability.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 15, 2023
@morrowwolf
Copy link
Member

Fill this out please:

Gameplay:
Does it feel good to use?
Does it feel good to play against?
Does it affect other systems?

Roleplay:
Does it increase immersion?
Does it increase communication/interaction between players?

Simulation:
Does it fit in the CM universe aesthetically?
Does it fit in the lore of CM?
Does it make sense “realistically”

@morrowwolf morrowwolf marked this pull request as draft July 19, 2023 07:05
@Ben10083
Copy link
Contributor Author

Ben10083 commented Jul 19, 2023

@morrowwolf
Gameplay:
Does it feel good to use?
Hiding as it stands makes it so you appear under items instead of over them, this however does NOT mean you could 'hide' under a bullet. As such, unless you are playing against predators or synths, you will not feel much of a impact with this change, outside of the obvious element of no longer hiding
Does it feel good to play against?
If you ARE having to fight a xenomorph using melee, this change would make it so it is more fair, as they can no longer use hide to hide their sprite to make it hard for you to retaliate against them (by going under table to make it so you lose your item, for example.)
Does it affect other systems?
To my knowledge, hiding only affects what layer the xenomorph is on.

Roleplay:
Does it increase immersion?
A xenomorph no longer would be slashing you, running under a table, and staying at the table to avoid getting hit.
Does it increase communication/interaction between players?
No, this is a combat-related change

Simulation:
Does it fit in the CM universe aesthetically?
Yes
Does it fit in the lore of CM?
Yes
Does it make sense “realistically”
Yes, when it is time to start attacking someone, the time to hide is over. If the battle ends up not going your way, the cooldown should be low enough where you can activate hide once more and use it to help you escape. Overall this change should only deter those who use hide actively in combat for the purpose of hiding their sprite.

@Ben10083 Ben10083 marked this pull request as ready for review July 19, 2023 12:43
@morrowwolf morrowwolf marked this pull request as draft July 20, 2023 10:27
@Ben10083 Ben10083 marked this pull request as ready for review July 20, 2023 18:16
@Ben10083 Ben10083 requested a review from morrowwolf July 20, 2023 18:16
@morrowwolf morrowwolf added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 24, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 4cd36ed Jul 24, 2023
github-actions bot added a commit that referenced this pull request Jul 24, 2023
cm13-github added a commit that referenced this pull request Jul 24, 2023
@Ben10083 Ben10083 deleted the Slash_X_Hiding branch July 24, 2023 21:08
@Drulikar Drulikar mentioned this pull request Jul 25, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2023
# About the pull request

This PR makes it so the xenohide ability requires the xeno to not be
busy (such as channeling a pounce). #3902 almost addressed this, but not
in the scenario of not being hidden -> pounce start -> insta hide.

# Explain why it's good for the game

Fixes working around unhide mechanics like this (can be much faster than
my example but I just had hide bound to a separate key):
https://cdn.discordapp.com/attachments/745447048261795890/1133194895918649354/hug.mp4

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

See above.

</details>


# Changelog
:cl: Drathek
fix: Fixed xeno hide ability not checking for busy status.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants