-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to squad color code #3908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
deletes nanoui/html
Code Improvement
Make the code longer
labels
Jul 16, 2023
BeagleGaming1
added
the
Needs Testing
Need to test it on the guinea pigs (production server)
label
Jul 16, 2023
I have probably broken so much with this PR. It worked locally but I don't know how it will go with more players |
harryob
requested changes
Jul 18, 2023
harryob
approved these changes
Jul 18, 2023
3 tasks
Found some bugs from the test merge:
|
3 tasks
3 tasks
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Needs Testing
Need to test it on the guinea pigs (production server)
UI
deletes nanoui/html
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Changes the squad text and equipment colors from a list into a variable that can be edited
Explain why it's good for the game
This allows the squad information to be edited much easier mid-round, allowing the creation of new squads with new colors, and edits to pre-existing squads.
Changelog
🆑
code: Changed squad color code from a list to a variable
/:cl: