-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes eggs off hive weeds #4459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
label
Sep 21, 2023
Segrain
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
cm13-github
added a commit
that referenced
this pull request
Sep 22, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> [Forum Thread](https://forum.cm-ss13.com/t/eggsac-carrier-revival/4711) # About the pull request The concept of this PR is to find a middle ground between the current eggsac carrier and the pre #4459 eggsac carrier. This PR will make the following changes. (From this point "normal weeds" can be substituted for "off hive weeds" Placing eggs on hive weeds is **unchanged**.) - Eggsac carrier can once again place eggs on normal weeds. - Eggsac carrier can only place 4 eggs at once on normal weeds. - If the Eggsac places more than 4 eggs on normal weeds, their oldest placed egg will die. No hugger release. - Eggs placed on normal weeds have a maximum lifetime of 5 MINUTES after which they will die. No hugger release. - Eggs placed on normal weeds have a 1 MINUTE life whilst the carrier is further than 14 tiles away from them. - If the carrier dies, all of their sustained eggs die. # Explain why it's good for the game Eggsac carrier at the moment is in a bit of a poor place and has gone from being very strong to quite poor. Considering the limitation of having to place only on hive weeds. The majority of feedback I read against eggsac carrier was with the quantity of eggs able to be placed, as well as the locations they can be placed in, all across the map and with impunity. This PR aims to address those concerns to make the eggsac both less infuriating to play against while still being satisfying to play as a frontline support or as a stealthy trapper. Eggs can no longer be placed all over the map because of the 4 egg limit off weeds, so the carrier has to think where they want to impact the map. The carrier also has to stay within a reasonable distance to where they are impacting with their eggs which localises their impact to their immediate play area. The carrier also has to be more reactive to current events as they cannot place an egg which then becomes useful 30 minutes later. Killing the carrier also has a small reward as in addition to removing a xeno from the game, the eggs they are sustaining are cleared. If a carrier is supporting the front and dies, the marines don't then have to clear X number of eggs AFTER the kill. # Testing Photographs and Procedure 1. Spawn as egg carrier. 2. Plant egg on normal weeds. 3. Move 15+ tiles away. 4. Wait 1 minute 5. OR Wait 5 minutes within 14 tiles. 6. Kill the carrier. The 5 minute lifetime of the eggs will also clear the eggs in the case that the carrier is admin deleted, or some other weird stuff happens which doesn't result in a death. This will also catch carriers de-evolving <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly label your changes in the changelog. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- If you add a name after the ':cl', that name will be used in the changelog. You must add your CKEY after the CL if your GitHub name doesn't match. Maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: add: Eggsac carrier can now place eggs on normal weeds to a maximum of 4 eggs. add: Eggsac carrier eggs on normal weeds have an expiry date. /:cl: <!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR removes eggs off hive weeds.
Explain why it's good for the game
Too strong, too many awkward layering issues to be abused.
I wanted to see if it'd create some sort of niche for egg sac carrier as carrier in general has been kind of left behind on the power curve especially since shaman removal. Sadly, it just wasn't meant to be.
As I said in #4015: "We'll revisit this in a couple weeks." Here we are.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Morrow
balance: Removed eggs off hive weeds for egg sac carrier
/:cl: