Get Flat Icon Fixes

[Drulikar]

About the pull request

This PR fixes two issues with getFlatIcon: It failing to properly resize its template dimensions to whatever icon dimensions it was passed, and it ignoring appearance_flags for RESET_COLOR and RESET_ALPHA. This was done to address issues with #4475 but can be even more performance costly than it already was because now it applies color and alpha blends per overlay/underlay layer rather than once per recursive call if there is a color/alpha to apply.

Explain why it's good for the game

Fixes the broader potential uses for getFlatIcon such as flattening the tacmap.

Testing Photographs and Procedure

Screenshots & Videos

Example of tacmap flattened prior to dimension fixes:

Example of tacmap flatted prior to color fixes:

Example of tacmap properly flattened:

Changelog

🆑 Drathek
fix: Fix getFlatIcon not resizing its template nor respect appearance_flags of RESET_COLOR and RESET_ALPHA
/:cl:

[morrowwolf]

So I'm not 100% on how the changes are working but would it be possible to put the more expensive stuff that's only needed for some things behind an argument or similar?

[Drulikar]

With appearance_flags default FALSE

If I were to make the default TRUE (so all use the fix):

No changes that I can tell - but should be the older performance. The new tacmap PR must opt in to this fix else all icons are colored incorrectly. I did also try to take a stab at why the vents appear layered wrong in photos, but I'm not sure yet why they don't sort correctly. TG's photo method is drastically different.