"Fixes" missing window frame icon states #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Sep 29, 2023
This was referenced Sep 30, 2023
harryob
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR "fixes" missing window frame icon states by just checking if they exist and if not then defaulting to base.
The vast majority of these are missing states 5, 6, 7, 9, 10, 11, 13, 14, 15 but some have them and others do not.
It's essentially a bandaid but until we get someone who wants to sprite 100ish icons 🤷
closes #2531
Explain why it's good for the game
Dealing with invisible window frames is super frustrating for everyone.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Morrow
fix: "Fixed" missing window frame icon states
/:cl: