Tentative Fix/Consistency for Dummy Limb Runtimes #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
added
Fix
harryob
requested changes
Oct 30, 2023
|
my bad |
harryob
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Tentative fix for a recurring runtime in dummy generation (eg. in character setup) caused by invalid limbs.
This is also a generally very bad spot in terms of deletions because it would prevent the organs from deleting properly, and prevent the limbs from being GC'ed.
As far as I can see only dummy preview and admin transform will cause cascading species change, so effect might not be obvious.
Tested for basic functionality (dummy render, running around, getting hit, healing).
Changelog
🆑
fix: Fixed Limbs and Organs deleting incorrectly on species change.
/:cl: