Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape-pod stasis fixes & ID checking proc #4960

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Nov 19, 2023

About the pull request

PR converts most places that are comparing registered_name on an ID, to a mob. I have left places that are explicitly checking for things without use of a direct user, as there are instances where this is necessary.
I have also fixed a missing check on escape pod stasis bays allowing xenos to put people into them.
In addition to the above change, I have set it so that people who were forced into stasis can eject themselves as there have been cases where people were removed from the round by this against their wishes.

Explain why it's good for the game

Makes little sense for xenos to be strapping marines into stasis bays. Nor for corpses to be accepted either, as they're not from the base version.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a proc for comparing the registered name of an ID, to the real name of a mob. Also checks registered_ref if one exists.
add: Evacuation can no longer be cancelled without passing above check.
add: People forced into escape-pod stasis bays against their wishes can now eject themselves.
fix: Xenos can no longer force humans into escape-pod stasis bays.
fix: Escape-pod stasis bays no longer accept corpses.
/:cl:

@realforest2001 realforest2001 changed the title Some ID/biometric checking Escape-pod stasis fixes & ID checking proc Nov 19, 2023
@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Nov 19, 2023
@restedwaves restedwaves mentioned this pull request Nov 26, 2023
3 tasks
@BadAtThisGame302 BadAtThisGame302 mentioned this pull request Nov 26, 2023
3 tasks
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 27, 2023
@github-actions github-actions bot closed this Dec 4, 2023
@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Dec 11, 2023
@Birdtalon Birdtalon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into cmss13-devs:master with commit b6380f7 Dec 18, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 18, 2023
@realforest2001 realforest2001 deleted the forest/biometrics branch December 18, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants