Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds antispam check similar to what sentrygun has to m56d #5246

Merged
merged 9 commits into from
Jan 1, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Dec 18, 2023

About the pull request

(doing this on a bench so it will need some cleanup sorry for that) adds check to placing the m56d that checks if there is another m56d in surounding area to prevent mg spam, numbers and stuff are placeholder it will get cleaned up ( I will be happy if you help me with it)

m56d spam has come to be an issue recently, I am part of it and do not want it to end up like omni sentryguns did (compleatly useless garbage) so I try to take better aproach to the balance then just AP or firerate nerf that would not solve the issue

Explain why it's good for the game

prevents m56d massing and encorages m56d users to spread out and cover diferent chokes instead of hosing down on and obliterating anyone who comes in the way

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: m56d can not be placed within five tiles of another one
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 18, 2023
code/modules/cm_marines/smartgun_mount.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/smartgun_mount.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/smartgun_mount.dm Outdated Show resolved Hide resolved
@Birdtalon Birdtalon marked this pull request as draft December 18, 2023 18:20
@cuberound cuberound marked this pull request as ready for review December 19, 2023 12:37
@cuberound
Copy link
Contributor Author

is 2 enough or should I increase?

@ihatethisengine
Copy link
Contributor

I personally believe you should make it at least 5, 2 is definitely not enough.

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Dec 24, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works except you can skip the check by placing a mount within the not allowed radius and then place the gun on the mount. So the same check has to apply to m56d_post as well.

@Drulikar Drulikar marked this pull request as draft December 24, 2023 01:13
code/modules/cm_marines/smartgun_mount.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/smartgun_mount.dm Show resolved Hide resolved
code/modules/cm_marines/smartgun_mount.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Added to TM so we can get more of an idea of its balance. Undraft when you are happy with it.

@cuberound cuberound marked this pull request as ready for review December 26, 2023 10:04
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you need to include the POSTS in your range check that's just gonna be confusing

@cuberound
Copy link
Contributor Author

i don't think you need to include the POSTS in your range check that's just gonna be confusing
you in fact do, as the post is also m56d just before you use screwdrive to finish it into the stage when it can shoot, so without it you can place down two posts, screw one finished and be unable to finish second one or interact with it at all/ be able to finish it and bypass the checks

@professionallyretarded professionallyretarded mentioned this pull request Dec 31, 2023
3 tasks
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jan 1, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Jan 1, 2024

If it needs tweaking in the future it can be handled then; but this seems reasonable to me when already sentries have a similar mechanic.

@Drulikar Drulikar added this pull request to the merge queue Jan 1, 2024
Merged via the queue into cmss13-devs:master with commit aee6a27 Jan 1, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants