A couple of M56D/M2C fixes #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime error: living_set_body_position overridden. Use override = TRUE to suppress this warning
Nothing should have been removed or added (other than combining the `UnregisterSignal()`s). This is just to make them a bit neater.
github-actions
bot
added
Fix
fira
approved these changes
Dec 29, 2023
Drulikar
added
the
Testmerge Candidate
3 tasks
3 tasks
3 tasks
realforest2001
approved these changes
Jan 3, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 3, 2024
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Some fixes and a small refactor for the M56D and M2C (since it's a subtype).
I was initially only planning to add a few
allow_gun_usagechecks around, but I just kept finding more things to fix.(I've tested this pretty thoroughly, but I'd still like to request a testmerge since a few of my other recent PRs have introduced new bugs.)
Explain why it's good for the game
Fixes bugs
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed non-combat synthetics being able to fire the M2C.
fix: Fixed scouts being able to use the M56D or M2C before their cloak's gun cooldown had ended.
fix: Fixed the M56D and M2C saying that the user is too far away to man it, even when they successfully man it.
fix: Fixed a runtime which was caused whenever someone manned an M56D or M2C.
refactor: Refactored some M56D and M2C manning/unmanning code.
/:cl: