Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulators demolition button #5359

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 1, 2024

About the pull request

This PR is a followup to #5318 that changed a var used to determine whether detonation is possible.

Explain why it's good for the game

Simulator is useless without this functionality.

Testing Photographs and Procedure

Screenshots & Videos

bombs

Changelog

🆑 Drathek
fix: Fixed simulators detonation button
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Fix Fix one bug, make ten more labels Jan 1, 2024
@fira
Copy link
Member

fira commented Jan 1, 2024

Seems it's now completely unused so you can remove it from CasSimData aswell no?

Remove unused var in CasSim
@Drulikar
Copy link
Contributor Author

Drulikar commented Jan 2, 2024

Retested:
image

@harryob harryob added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit 63b1ad6 Jan 6, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
@ghost
Copy link

ghost commented Jan 6, 2024

oversight, apologies.

@Drulikar Drulikar deleted the Fix_Simulator_Detonation branch January 8, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants