TGUI upgrades to support react migration #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
mullenpaul
added
the
Testmerge Candidate
3 tasks
|
I think this is making my chat bar resize randomly |
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
harryob
approved these changes
Jan 18, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Switches TGUI from Inferno to React. Part 2 of the PR #5435 Based heavily on the work from: https://github.com/tgstation/tgstation/pull/80044/files # Explain why it's good for the game React is a more suitable framework # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: refactor: switched from infernojs to react /:cl:
Doubleumc
pushed a commit
to Doubleumc/PvE-CMSS13
that referenced
this pull request
Jul 24, 2024
<!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Switches TGUI from Inferno to React. Part 2 of the PR cmss13-devs/cmss13#5435 Based heavily on the work from: https://github.com/tgstation/tgstation/pull/80044/files React is a more suitable framework <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> :cl: refactor: switched from infernojs to react /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Round of upgrades and changes to support migration to React for tgui. By doing more smaller changes I hope it's easier to review and test.
Explain why it's good for the game
We want to migrate from infernojs to react.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: upgraded root tgui files to typescript to closer align with tg
refactor: upgraded typescript to 4.9.4
refactor: upgraded yarn to 3.3.1
refactor: upgraded a bunch of tgui tooling
/:cl: