Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Fire Properties rework/rebalance #5519

Closed
wants to merge 20 commits into from

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Jan 22, 2024

About the pull request

This PR rebalances fire properties.
Fire properties are now exempt from the penalty that makes them ridiculously expensive to create after level 5.
Oxidizing no longer has -2 duration
Fueling no longer has -2 intensity
Flowing no longer has -1 intensity and -1 duration
All fire chems have been adjusted to remain the same as before
Welding fuel hardcoded snowflake properties removed
OT incinerator tank for normal flamer has had it's caps increased to 40 intensity and 40 duration (same as blue flame)

Explain why it's good for the game

Research fire properties right now are very expensive for something that is slightly better than normal flame, theres almost no point in making fire chems when you could spend those precious credits on something actually useful (MST NST stims) and is guaranteed to be used by marines unlike a fire chem, which requires the marine to have a flamer in the first place.
You're now able to make a blueflame tier chem with easy complexity for around 25-30 points + clearance 3.
You can now make a maxcap flame (only usable by pyro spec) for around 50 points + clearance 5.

Testing Photographs and Procedure

I tested it yeah. Might want to TM first tho
I humbly ask mantainers to please give this a thought and to not instantly close.

Changelog

🆑
balance: Oxidizing no longer has -2 duration.
balance: Fueling no longer has -2 intensity.
balance: Flowing no longer has -1 intensity and -1 duration.
balance: Welding fuel hardcoded snowflake properties removed, all other fire chems adjusted to match old stats.
balance: Tank for normal flamer has had it's caps increased to 40 intensity and 40 duration (same as blue flame).
balance: Custom Chemical burncolors will now always be either white or pink.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jan 22, 2024
@RenaRenaRe
Copy link
Contributor

Just so you're aware, changing the property levels for chems like welding fuel, thermite and napalm affects OT grenades, rockets, etc. So this is an unintentional(?) OT nerf. Your statement "All fire chems have been adjusted to remain the same as before" is only true for the flamer stats, so you've maintained flamer stats at the cost of nerfing the stats for things like grenades and rockets

@iloveloopers
Copy link
Contributor Author

Just so you're aware, changing the property levels for chems like welding fuel, thermite and napalm affects OT grenades, rockets, etc. So this is an unintentional(?) OT nerf. Your statement "All fire chems have been adjusted to remain the same as before" is only true for the flamer stats, so you've maintained flamer stats at the cost of nerfing the stats for things like grenades and rockets

added OT stats to the main flame chems used (they override properties).
reverted alcohol changes cause they're weak enough already and don't matter.

@iloveloopers
Copy link
Contributor Author

OT values fixed for thermite and napalm. (they're true to the wiki now)
welding fuel and CLF3 OT values removed
Welding fuel is objectively worse than both thermite and napalm and nobody uses it so it stays as is

@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Jan 25, 2024
@Nanu308
Copy link
Member

Nanu308 commented Jan 25, 2024

Willing to testmerge this and take a look myself on the balance aspect, but not promising that it's gonne get merged or accepted as it is

@iloveloopers
Copy link
Contributor Author

normal flamer tank max_duration raised to 40, meaning you no longer need to get the OT to print you custom tanks for you to reach the blueflame cap.
if Nanu considers this to remove too much department cooperation, I am willing to revert (though the only thing that the OT does is press a button on the armylathe and an MT can do it aswell).

@cuberound cuberound mentioned this pull request Jan 29, 2024
3 tasks
@Segrain Segrain self-requested a review January 30, 2024 19:25
@Segrain Segrain added the Do Not Merge If you merge this PR, I will annihilate you label Jan 30, 2024
@Segrain
Copy link
Contributor

Segrain commented Jan 30, 2024

I do believe that there has been quite public announcement: changes to research are not currently accepted. I do not understand what makes you think that this is somehow an exception.

Even that procedural point aside, this PR has been on testmerge for a few days by now, and after observing multiple times how it ends being used I can only say "no, please no, absolutely not", for reasons which are mostly not code review and do not quite belong here. Just in case management would disagree and want to scream at me about it, I am not closing the PR outright with extreme prejudice, but if you will approve and merge this without telling me, I will scream at you too.

@iloveloopers
Copy link
Contributor Author

removed the exemption of fire properties from the penalty that is added above level 5 on create mod, price is now slightly increased.
custom flames burncolor will now always be either white or pink (50/50 chance) to avoid confusion by xenos.

Segrain makes some fair points, though I believe the ultimate decision will be made by management

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 7, 2024
@github-actions github-actions bot closed this Feb 14, 2024
@iloveloopers iloveloopers deleted the FIRE!!! branch May 24, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Do Not Merge If you merge this PR, I will annihilate you Needs Testing Need to test it on the guinea pigs (production server) Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants