Makes observers able to see the UI of Xeno players (and also action buttons) #5751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to already work surprisingly well with the xeno HUD (I'll test it more though).
also added something to the tips pool because I had no idea about it
fira
reviewed
Feb 19, 2024
Made `/mob/living/carbon/human/auto_observed()` just get the target's active inventory rather than looping through their contents. Also made build mode not show to observing players.
Not sure why I didn't just do this in the first place...
harryob
approved these changes
Feb 21, 2024
cm13-github
added a commit
that referenced
this pull request
Feb 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2024
# About the pull request Fixes/tweaks a couple of auto-observe things that I noticed after #5751. Specifically: - Fixes `runtime error: client_screen_add overridden. Use override = TRUE to suppress this warning`/`runtime error: client_screen_remove overridden. Use override = TRUE to suppress this warning`. *This error was consistently thrown when a ghost who's body is being observed re-enters their body. `observe_target_new_mind()` tries to re-register the some signals on the body's new client, but didn't have the `override` argument set.* - Stops 'hidden' actions being added to the screen of observing players. (e.g. the xeno tacmap action if the queen isn't ovied) - Makes any observers transfer over to the new body when a xenomorph evolves/de-evolves. *(I also added `/mob/dead/observer` to the `observers` variable's declaration since it wasn't particularly clear what the list held.)* - Fixes the target player's action buttons disappearing for observers if they reconnect or re-enter their body. *(The actions were being shown to the player in `Login()`>`show_hud()`>`update_action_buttons()` before the observer could re-register signals in `observe_target_login()`.) In order to fix this I renamed the existing `COMSIG_GLOB_MOB_LOGIN`, `COMSIG_CLIENT_MOB_LOGIN`, `COMSIG_MOB_LOGIN` signals, and made `COMSIG_MOB_LOGIN` send a bit earlier in the proc.* # Explain why it's good for the game Bugfixes :) # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Fixed 'hidden' action buttons being shown to observing players. qol: Made any observers transfer over when a Xenomorph evolves/de-evolves. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes auto-observing work for xenomorphs and humans by moving it to
/carbon, and also makes it show the target's action buttons.I'm pretty confident that this all works correctly, but I would still recommend testmerging it anyway.
It's
probablepossible that I missed something somewhere and an observer could get stuck being unable to click anything, or something like that.Explain why it's good for the game
This makes auto-observing a bit more consistent, more interesting for observers, and could actually help newer players to learn how to play some castes. (Which abilities to use and when, where to target, etc.)
Testing Photographs and Procedure
Screenshots & Videos
output.mp4
Changelog
🆑
add: Added 'observe' functionality to Xenomorphs, allowing observers to view the target's UI.
add: Made observing a player also show their action buttons.
/:cl: