Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Dropship turf direction sprites (#3642)" #5817

Closed
wants to merge 1 commit into from
Closed

Revert "Dropship turf direction sprites (#3642)" #5817

wants to merge 1 commit into from

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 26, 2024 •
edited
Loading

This reverts commit ec4ab3a.

About the pull request

image

runtime error: Maximum recursion level reached (perhaps there is an infinite loop)
To avoid this safety check, set world.loop_checks=0.
proc name: on dir change (/obj/structure/dropship_equipment/proc/on_dir_change)
  usr: Some One (/mob/living/carbon/human)
  src: the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod)
  usr.loc: the floor (97,61,3) (/turf/open/floor/almayer)
  src.loc: the plating (96,61,3) (/turf/open/floor/plating)
  call stack:
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): on dir change(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), 2, 4)
CallAsync(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), "on_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod):  SendSignal("atom_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): setDir(4)
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): update equipment()
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): on dir change(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), 2, 4)
CallAsync(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), "on_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod):  SendSignal("atom_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): setDir(4)
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): update equipment()
...
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): setDir(4)
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): on dir change(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), 2, 4)
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod):  SendSignal("atom_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): update equipment()
CallAsync(the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod), "on_dir_change", /list (/list))
the LAU-444 Guided Missile Lau... (/obj/structure/dropship_equipment/weapon/rocket_pod): setDir(4)
the starboard wing weapon atta... (/obj/effect/attach_point/weapon/dropship2/right_wing): install equipment(the Power Loader Left Hydrauli... (/obj/item/powerloader_clamp), Some One (/mob/living/carbon/human))

@Drulikar Drulikar added the Test Merge Only This PR's purpose is for testmerges only. label Feb 26, 2024
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? labels Feb 26, 2024
cm13-github added a commit that referenced this pull request Feb 26, 2024
@cm13-github
TGS Test Merge (#5817)
239e652 
Temporary infinite loop fix when equipping dropship equipment
cm13-github added a commit that referenced this pull request Feb 26, 2024
@cm13-github
TGS Test Merge (#5817)
6b57804 
Temporary infinite loop fix when equipping dropship equipment
cm13-github added a commit that referenced this pull request Feb 26, 2024
@cm13-github
TGS Test Merge (#5817)
c3f4c24 
Temporary infinite loop fix when equipping dropship equipment
@mullenpaul mullenpaul mentioned this pull request Feb 26, 2024
Merged
cm13-github added a commit that referenced this pull request Feb 26, 2024
@cm13-github
TGS Test Merge (#5817)
7e2d1b6 
Temporary infinite loop fix when equipping dropship equipment
@spaceboi123 spaceboi123 mentioned this pull request Feb 26, 2024
Closed
3 tasks
cm13-github added a commit that referenced this pull request Feb 26, 2024
@cm13-github
TGS Test Merge (#5817)
90da2fa 
Temporary infinite loop fix when equipping dropship equipment
@Nanu308 Nanu308 mentioned this pull request Feb 26, 2024
Open
3 tasks
cm13-github added a commit that referenced this pull request Feb 27, 2024
@cm13-github
TGS Test Merge (#5817)
ae5f479 
Temporary infinite loop fix when equipping dropship equipment
cm13-github added a commit that referenced this pull request Feb 27, 2024
@cm13-github
TGS Test Merge (#5817)
637cebb 
Temporary infinite loop fix when equipping dropship equipment
cm13-github added a commit that referenced this pull request Feb 28, 2024
@cm13-github
TGS Test Merge (#5817)
31f120a 
Temporary infinite loop fix when equipping dropship equipment
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2024
@mullenpaul
Fix dropship equipment infinite loop (#5823)
187a5fc 
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
Resolves issue patched by
#5817
# Explain why it's good for the game
Bugs are bad

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
code: removed duplicated signal code from dropship equipment
/:cl:
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 28, 2024
@Drulikar
Copy link
Contributor Author

Resolved

@Drulikar Drulikar closed this Feb 28, 2024
@Drulikar Drulikar deleted the Revert_Dropship_Rotation branch February 28, 2024 10:51
Doubleumc pushed a commit to Doubleumc/PvE-CMSS13 that referenced this pull request Jul 26, 2024
@mullenpaul @Doubleumc
Fix dropship equipment infinite loop (#5823)
effc9ad 
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
Resolves issue patched by
cmss13-devs/cmss13#5817
Bugs are bad

<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>

:cl:
code: removed duplicated signal code from dropship equipment
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Awaiting requested review from Nanu308 Nanu308 is a code owner

Assignees
No one assigned
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game. Test Merge Only This PR's purpose is for testmerges only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drulikar @cm13-github