-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resprites - 2/2024 Edition #5838
Conversation
…into resprites-2-24
…into resprites-2-24
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
382b52f
to
5f9d3e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks great sprite-wise minus a few gripes
the values on the mortar shells are a little dull. i think they need a darker shade for an outline/accentuating the fins, and a sharper highlight to give it a more metallic look. the base palette also has a couple basically identical shades of grey
the groove on the lid (i have no idea what to call it 😭) of the coffins change position between closed and open versions. i do not know if that's intentional or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprites now approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine. However a bit too many changes to verify so will TM a round or two to see if anyone notices anything wonky.
# About the pull request Apparently a little `pills_closed` bottle overlay got accidentally obliterated in one of my commits from #5838 a while back. Whoops. This fixes it. Pill bottles should once again don their hats when they're not opened. # Changelog :cl: nauticall fix: Makes pill bottle caps appear on closed pill bottles again. /:cl:
# About the pull request Adds a Pizza Galaxy space diner to the game for the Pizza ERT. They deserve their own station as well! The clothed tables will spawn incorrectly spritewise until Naut's PR #5838 is added to the game. Once new cooking sprites are added I'll go back and tweak the kitchen area some more. # Explain why it's good for the game More Soulful lore and RP spots. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ![bilde](https://github.com/cmss13-devs/cmss13/assets/59782240/d740b48b-a3bf-44ee-bc41-a2579ab32bd5) </details> # Changelog :cl: mapadd: Added the Galaxy Pizza Space Diner ERT station, for all your outer expanse food needs! maptweak: Placed APC's on ert stations and minor tweaks+fixes. /:cl: --------- Co-authored-by: Drathek <[email protected]>
About the pull request
Resprites various items in the game to be subjectively prettier and more up-to-date with modern standards. Among them are the following:
Explain why it's good for the game
Sprites
Sprites
Changelog
🆑 nauticall
imageadd: Resprites first aid kits, coffins, material stacks, mortar shells, and chemistry items. Chemistry sprites ported from Baystation / Aurora.
fix: Recolors several reagent sprites to be more in-line with their established colors, such as on autoinjectors.
fix: Fixed invisible cloth tables.
fix: Fixed wrong shading on the large floodlight.
/:cl: