Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Med skill rebalance Mk2 #5937

Closed
wants to merge 4 commits into from
Closed

Med skill rebalance Mk2 #5937

wants to merge 4 commits into from

Conversation

Katskan
Copy link
Contributor

@Katskan Katskan commented Mar 13, 2024

About the pull request

2 main things, the medical 4 generalized multiplier changed to a non-standard value of 0.35, 10% less than it was before but 15% better than most recent. The other part is changing how medical skill affects defibrillators, with medical 4 shocking right as defibrillators finish their charge sound. Medical 2 is still unaffected by how the math works.

Explain why it's good for the game

Keeps some of the splint/inject/CPR time from before, while maximizing the speed you can get before the shock sound.

Testing Photographs and Procedure

Please TM

Tested on local server to make sure all the scaling worked properly.

Changelog

🆑
balance: changed medical 4 skill speed multiplier from tier 2 to a non-standard 0.35
balance: changed defib medical skill speed scaling
/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 13, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 13, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Mar 14, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corpsman 7.0 seconds (2/4 medical)
CLF Synth 6.25 seconds (3/4 medical)
USCM Synth 5.05 seconds (4/4 medical)

@Drulikar Drulikar added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Mar 14, 2024
cm13-github added a commit that referenced this pull request Mar 14, 2024
@TheGamerdk
Copy link
Contributor

TheGamerdk commented Mar 14, 2024

Compared to before:

Pre-nerfs (Only relevant to shipside synthetic): 1,75
Post-nerf, pre-this: 3,5
This: 5.05

Approx. 65% slower

@Katskan Katskan closed this by deleting the head repository Mar 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 17, 2024
# About the pull request

Got demons in my code, removed them from #5937 .

This does 2 main things, the medical 4 generalized multiplier changed to
a non-standard value of 0.35, 10% less than it was before but 15% better
than most recent. The other part is changing how medical skill affects
defibrillators, with medical 4 shocking right as defibrillators finish
their charge sound. Medical 2 is still unaffected by how the math works.
# Explain why it's good for the game

Keeps some of the splint/inject/CPR time from before, while maximizing
the speed you can get before the shock sound.

# Testing Photographs and Procedure

Please TM

Tested on local server to make sure all the scaling worked properly.

# Changelog

:cl:
balance: changed medical 4 skill speed multiplier from tier 2 to a
non-standard 0.35
balance: changed defib medical skill speed scaling
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants