Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Strength Grab Changes (Never skip arm day) #6020

Merged
merged 13 commits into from
Apr 6, 2024

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Mar 27, 2024

About the pull request

Grabs for those with super strength buffed

  • passive grabs no longer guarantied resist
  • target has reduced chance to resist
  • if the target, increased chance to resist
  • if both have super strength, works as before (passive grabs guarantied for example)

Explain why it's good for the game

Grabs are not often used, even though roles such as WJs are encouraged to do so. This is because grabs are very easy to be resisted out of. This is fine, and is necessary, but in this case, I want to have it so if someone has an advantage in strength, they have advantage in this exchange (both dealing and recieving).

I feel this was more an oversight, as logically those who are stronger will have a stronger grip than otherwise.

The balance out between the two is to prevent shenanigans between synth and pred, no grab fights there.

scenario 1)
Synth vs Human
Synth has strength, human doesn't
advantage synth

scenario 2)
human vs Pred
Pred has strength, human doesnt
advantage pred

scenario 3)
Synth vs Pred
Both have strength
No advantage (how it is now)

Changelog

🆑
balance: Mobs with super strength now have an advantage when resisting of a grab is done, both as the grabber and the one being grabbed (Xenos not affected, works as before).
balance: Mobs with super strength no longer have their passive grabs a guaranteed resist (unless both super).
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 27, 2024
@Ben10083
Copy link
Contributor Author

Ben10083 commented Mar 28, 2024

Quick exception for xenos added (warrior grabs wont be easier to resist) for balance reasons. Justified by warriors likely also being 'super strong'

code/modules/mob/living/carbon/human/human_helpers.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_helpers.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
@Ben10083 Ben10083 requested a review from SabreML March 31, 2024 18:15
@Ben10083 Ben10083 requested a review from SabreML April 1, 2024 00:24
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved, still need a balance review. 👍

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 4, 2024
cm13-github added a commit that referenced this pull request Apr 5, 2024
cm13-github added a commit that referenced this pull request Apr 5, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 6, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 6, 2024
Merged via the queue into cmss13-devs:master with commit c94bda6 Apr 6, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants