Corrupted Queen can set up personal alliances with humans #6155
Conversation
github-actions
bot
added
Sprites
There was a problem hiding this comment.
To sum up some things mentioned in other comments:
- Typing consistency across code - this could also be generalized to /mob or /mob/living
- Missing post alert/input checks in adding/removing/clearing allies, things can change during the dialogs
- You can't just sanitize deleted mobs once in a while, they need to be cleared immediately by signal or just using a weakref
As extra points I'd like to bring up, hardcoding this to Corrupted hive is bit of a shame. This could be made into a feature toggleable for all hives from the get-go. You could also two-birds-one-stone it by using a component hooked to is_ally instead of bothering with CORRUPTED_ALLY at all. But both of these are secondary points...
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
That was a requirement set by me. But if you'd rather it be a variable that only corrupted has by default set so an admin can toggle it on for other hives, sure. Also of note, other research hives this is fine for; but I don't think it appropriate for normal hive. |
|
HUDs is another reason I went for hardcode because making personal HUDs for every hive just for a feature that meant to be corrupted only sounds like a big overkill.
As far as I now, only corrupted (and renegades, but they don't have queen so it doesn't matter) can act friendly towards humans. I.e. Alpha hive should always be hostile even if research makes them. Anyway, tell me if you need this feature for all hives and I will look what can I do. If not, I prefer to keep it simple. |
Won't I need to sanitize weekrefs once in a while anyway? |
Yeah I meant this purely codewise, it can be incorporated into global hive code and disabled when not appropriate rather than hardcoded and require a refactor if used elsewhere. But it might just be wishful thinking, if we really have no use case for it, it's not worth bothering
You can pop invalid ones out of the list if you want, but i'd say it's not a requirement for something low traffic like this |
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/queen/queen_powers.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: Drathek <[email protected]>
Drulikar
added
the
Testmerge Candidate
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Corrupted queen can mark people of her choice (within her view) as allies. Corrupted xenos won't be able to harm them. Just as regular alliances, personal alliances break on queen's death. Synths are human subtypes so you can ally them too.
Credits to @SubjectD9341 for the sprites.
Explain why it's good for the game
More roleplay :)
ally.mp4
Testing Photographs and Procedure
Changelog
🆑 ihatethisengine
add: Corrupted Queen can set up personal alliances with humans
/:cl: