Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes delaying round start not showing on the timer. #6166

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Apr 18, 2024

About the pull request

As title

Explain why it's good for the game

It's not always clear if it's been delayed or somehow broken anymore.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Delaying round start now shows on the timer again.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 18, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You likely want to also change /mob/new_player/get_status_tab_items() too then because at the moment, this only affects admins who observe before game start.

code/modules/mob/dead/observer/observer.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 20, 2024 04:33
@realforest2001
Copy link
Member Author

No idea how I missed new_player

@realforest2001 realforest2001 marked this pull request as ready for review April 20, 2024 12:18
code/modules/mob/new_player/new_player.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge April 21, 2024 07:06
@Drulikar Drulikar added this pull request to the merge queue Apr 21, 2024
Merged via the queue into cmss13-devs:master with commit 1ca0f69 Apr 21, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 21, 2024
@realforest2001 realforest2001 deleted the forest/delayfix branch May 10, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants