Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fences can be shot through #6178

Merged
merged 1 commit into from
May 10, 2024
Merged

fences can be shot through #6178

merged 1 commit into from
May 10, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Apr 21, 2024 •
edited by github-actions bot
Loading

About the pull request

gives a flag for fences to make bullets gas and spits (not throwables) pass cades

Explain why it's good for the game

being unable to shoot thrue fences is a bit weard, might prove OP so TM first and there might be need for changes or rewert

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: projectiles can pass fences
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 21, 2024
@cuberound cuberound changed the title shootthrue fences fences can be shot thrue Apr 21, 2024
@cuberound cuberound changed the title fences can be shot thrue fences can be shot through Apr 22, 2024
fira
fira previously requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throwpass does other things too i'm pretty sure...

If all you're looking to do is alter the bullet hit logic, you could instead override get_projectile_hit_boolean

@Drulikar Drulikar added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Apr 24, 2024
@Drulikar
Copy link
Contributor

I'm pretty sure throwpass is fine but I guess we can see.

cm13-github added a commit that referenced this pull request Apr 24, 2024
@cm13-github
TGS Test Merge (#6178)
21300bb
@PurpleCIoud PurpleCIoud mentioned this pull request Apr 24, 2024
Closed
3 tasks
cm13-github added a commit that referenced this pull request Apr 24, 2024
@cm13-github
TGS Test Merge (#6178)
f54abb0
cm13-github added a commit that referenced this pull request Apr 24, 2024
@cm13-github
TGS Test Merge (#6178)
4b68468
cm13-github added a commit that referenced this pull request Apr 25, 2024
@cm13-github
TGS Test Merge (#6178)
19976db
cm13-github added a commit that referenced this pull request Apr 25, 2024
@cm13-github
TGS Test Merge (#6178)
f9f6a37
cm13-github added a commit that referenced this pull request Apr 25, 2024
@cm13-github
TGS Test Merge (#6178)
35fb409
cm13-github added a commit that referenced this pull request Apr 26, 2024
@cm13-github
TGS Test Merge (#6178)
24b19e7
cm13-github added a commit that referenced this pull request Apr 26, 2024
@cm13-github
TGS Test Merge (#6178)
888ccb0
cm13-github added a commit that referenced this pull request Apr 26, 2024
@cm13-github
TGS Test Merge (#6178)
81aca30
cm13-github added a commit that referenced this pull request Apr 26, 2024
@cm13-github
TGS Test Merge (#6178)
9a09f01
cm13-github added a commit that referenced this pull request Apr 27, 2024
@cm13-github
TGS Test Merge (#6178)
ff8b5c9
cm13-github added a commit that referenced this pull request Apr 27, 2024
@cm13-github
TGS Test Merge (#6178)
564c951
@Shibouze Shibouze mentioned this pull request Apr 27, 2024
Closed
3 tasks
@Biolock1 Biolock1 mentioned this pull request Apr 28, 2024
Closed
3 tasks
cm13-github added a commit that referenced this pull request Apr 28, 2024
@cm13-github
TGS Test Merge (#6178)
0c72ac3
cm13-github added a commit that referenced this pull request Apr 29, 2024
@cm13-github
TGS Test Merge (#6178)
32dc2b2
cm13-github added a commit that referenced this pull request Apr 29, 2024
@cm13-github
TGS Test Merge (#6178)
9a93eb9
cm13-github added a commit that referenced this pull request Apr 29, 2024
@cm13-github
TGS Test Merge (#6178)
77d5d37
@SolaAqua SolaAqua mentioned this pull request Apr 30, 2024
Closed
3 tasks
cm13-github added a commit that referenced this pull request Apr 30, 2024
@cm13-github
TGS Test Merge (#6178)
9af3d39
cm13-github added a commit that referenced this pull request Apr 30, 2024
@cm13-github
TGS Test Merge (#6178)
c587861
cm13-github added a commit that referenced this pull request May 5, 2024
@cm13-github
TGS Test Merge (#6178)
a6815f5
cm13-github added a commit that referenced this pull request May 5, 2024
@cm13-github
TGS Test Merge (#6178)
1d707d6
cm13-github added a commit that referenced this pull request May 5, 2024
@cm13-github
TGS Test Merge (#6178)
1a94b3e
cm13-github added a commit that referenced this pull request May 6, 2024
@cm13-github
TGS Test Merge (#6178)
041a358
cm13-github added a commit that referenced this pull request May 6, 2024
@cm13-github
TGS Test Merge (#6178)
d7d2f27
cm13-github added a commit that referenced this pull request May 7, 2024
@cm13-github
TGS Test Merge (#6178)
7e62c2a
cm13-github added a commit that referenced this pull request May 8, 2024
@cm13-github
TGS Test Merge (#6178)
d969f29
cm13-github added a commit that referenced this pull request May 8, 2024
@cm13-github
TGS Test Merge (#6178)
3908d8a
cm13-github added a commit that referenced this pull request May 8, 2024
@cm13-github
TGS Test Merge (#6178)
d85c108
cm13-github added a commit that referenced this pull request May 8, 2024
@cm13-github
TGS Test Merge (#6178)
64e9a31
cm13-github added a commit that referenced this pull request May 8, 2024
@cm13-github
TGS Test Merge (#6178)
08344f4
@github-actions github-actions bot closed this May 9, 2024
@Drulikar Drulikar reopened this May 9, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label May 9, 2024
cm13-github added a commit that referenced this pull request May 9, 2024
@cm13-github
TGS Test Merge (#6178)
74f2936
cm13-github added a commit that referenced this pull request May 9, 2024
@cm13-github
TGS Test Merge (#6178)
0c7bcc2
cm13-github added a commit that referenced this pull request May 9, 2024
@cm13-github
TGS Test Merge (#6178)
e0c3214
cm13-github added a commit that referenced this pull request May 10, 2024
@cm13-github
TGS Test Merge (#6178)
d8196cc
cm13-github added a commit that referenced this pull request May 10, 2024
@cm13-github
TGS Test Merge (#6178)
e0f6c4f
@Drulikar Drulikar added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Needs Testing Need to test it on the guinea pigs (production server) labels May 10, 2024
@Drulikar Drulikar dismissed fira’s stale review May 10, 2024 04:50

Does not appear to be an issue.

@Drulikar Drulikar added this pull request to the merge queue May 10, 2024
Merged via the queue into cmss13-devs:master with commit 8659dff May 10, 2024
54 checks passed
cm13-github added a commit that referenced this pull request May 10, 2024
@cm13-github
Automatic changelog for PR #6178 [ci skip]
995e211
@Vermidia Vermidia mentioned this pull request Jul 23, 2024
Closed
@KoishiVibe KoishiVibe mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realforest2001 realforest2001 realforest2001 approved these changes

@Drulikar Drulikar Drulikar approved these changes

@fira fira fira left review comments

Assignees
No one assigned
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuberound @Drulikar @fira @realforest2001 @uuuuhuuuu