Scout Cloak fix #6742
Closed
Scout Cloak fix #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Jul 17, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 17, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 17, 2024
3 tasks
This was referenced Jul 18, 2024
3 tasks
|
#6756 fixes the whole issue |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
# About the pull request Calling the parent of all actions (#6442) caused a lot of bugs, this fixes that. Closes #6755 Closes #6753 Closes #6732 Closes #6742 # Explain why it's good for the game Bugs are bad # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Tested on practically every object that has a use-in-hand functionality with an action button. </details> # Changelog :cl: fix: Fixed a large amount of objects activating erroneous functionality (like an armor light) when using action buttons tied to that object. /:cl: Co-authored-by: John Doe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes scout keybind
This is sure one of a rabbit hole, Due to abominations tutorial, all actions call parent now, that calls parent action_activate, that calls ui_action_click, That calls parent ui_action_click on item type, and item type calls attack_self on itself, which activates the cloak again. we fix it by tactically nuking the camouflaging part in self attack.
fixes #6732
Explain why it's good for the game
Keybind working good
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Scout cloak is working again.
/:cl: