-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research Rework Part Two: The Contract System. #7023
Open
kiVts
wants to merge
96
commits into
cmss13-devs:master
Choose a base branch
from
kiVts:xenos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
UI
deletes nanoui/html
Removal
snap
Feature
Feature coder badge
labels
Aug 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
# About the pull request made the plates actually work. Fixes #7142 All code was made by kiVts, I just took the code and made a PR for them now because #7023 is on draft until it's done. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game The things that research spends biomass points on should work??? # Testing Photographs and Procedure tested on a private server, stabbed myself a few times with a knife, no bloodloss, injector plate works (with all OD modes functional). # Changelog :cl: Private-Tristan, KiVts fix: Injector and Coagulator plates are now functional. /:cl:
Co-authored-by: private-tristan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Massively revamps the main gameplay loop of research, Tons of changes, an attempt to make research more independent and less afk based gameplay, There are tons of changes to be covered.
To start, research had their passive gain nuked completely. They now get a free chemical to pick every 5 minutes(Subject to change) (2 if none picked(Subject to change)), with three levels of difficulty, with hard having hydro-exclusive chemicals, credit reward is substantially higher though, so think carefully.
Create mode was also removed, the cornerstone of every godstim, impossible to balance in a way to make not hoarding points the best way without hindering the other more healthier options. As a counterbalance, randomly generated chemicals have had their OD average increased considerably, and a new "ADD" mode, in which you can add a property from reference chemical without downsides to the target chemical, however the reference chemical will refuse any further interactions in the simulator(Subject to change).
Legendary properties are no longer generated in the chemicals, instead, they're now assigned 3 properties randomly each round, which when mixed, combines into the property. Documents telling exactly which properties can be found groundside, for that reason, recent legendary properties nerfs are reverted back into their original form. Ciphering also falls into the same fate, Royal plasma now has "Encrypted" property (Subject to change), which is only one key out of four to making ciphering, a minor hint is found in CMO office, while the rest in groundside.
Pregenerated chemicals are removed, Those are the chemicals you would encounter in the hydro plants, Groundside vials, and researcher labcoat. Groundside vials now only contain extremely rare chemicals like Thwei, and etc, the chance to have such vials are lowered substantially.
Hydro has 10(9? I forgot) new chemicals exclusive to them, all of them are also exclusive to certain plants, and most of them exist in the real world (Albeit, the plants you find them in are not), those pop up in the hard tier chemicals mentioned earlier.
Credit disks in the dissection analyzer are replaced for contract reroll, buying which will instantly reroll the contracts, bought or not.(Subject to change)
WIP, although most of it is done, I need to do some massive polish and repair. (seed datum code, look at it its insane) PRed so I can track the changes more easily and Im rapidly approaching the end.
This will also need a huge amount of price and rarity rabalance, perhaps the most pain will be brought by property generation.
Explain why it's good for the game
Research suffers from huge amounts of issues to the point that writing them out here would take hours, however there are main things to point out
Meta - The research meta was often attempted to be destroyed, the result was often, disappointing and nerfs only swirled up the meta, if at all (example being MST recieving 3(4?) nerfs in the years of researching), This way we attempt to
AFK/Heavily groundside reliant gameplay - The passive gain would heavily promote to just afk out of boredom, and the huge reliance on groundside IOs is not exactly healthy for the department, their perfomance being largely out of their hands. We try to fix this, by
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
del: Create mode is removed
del: Chemicals that appear in vials are gone.
add: Contract system for research, Research gets a choice of 3 chemicals every 5 minutes (2 if not picked), of random difficulty. Level of difficulty affects the quality of properties and complexity of the recipe, however, the harder - the more points you get to manipulate the chemical in synthesis simulator.
add: ADD mode in synthesis simulator, This is a replacement to CREATE mode, in this mode you can add a property to target chemical at no disadvantage for the target chemical, however the reference chemical is "damage" and simulator wont accept it anymore.
add: 9 Hydro exclusive chemicals. Atropine, more powerful epinephrine but deals brain damage, Thymol an extremely weak anti parasitic, Psoralen a powerful carcinogenic and more. Found only in certain plants during a mutagenic process.
del: Passive income for research is removed.
add: Legendary properties will not generate in chemicals anymore, instead they're now assigned 3 properties to combine from, similar applies to ciphering.
fix: Coagulator plate now works
/:cl: