-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the preference to trigger xeno/human abilities with right click instead of middle click or shift click #7123
Merged
harryob
merged 3 commits into
cmss13-devs:master
from
Watermelon914:right-click-ability-proc
Sep 10, 2024
Merged
Adds the preference to trigger xeno/human abilities with right click instead of middle click or shift click #7123
harryob
merged 3 commits into
cmss13-devs:master
from
Watermelon914:right-click-ability-proc
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leclick/shiftclick
cm13-github
added a commit
that referenced
this pull request
Sep 6, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 6, 2024
can no longer point using the default shift + MMB with an ability active to specify it will try and use the ability instead pointing |
fixed |
cm13-github
added a commit
that referenced
this pull request
Sep 7, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 7, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Sep 7, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to take TM off, these two spaces are causing a conflict for #7087
cm13-github
added a commit
that referenced
this pull request
Sep 8, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 9, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 9, 2024
harryob
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
As the title says. Adds a new preference option that can be toggled between middle clicking and shift clicking. When enabled, if you have a xeno ability active, the right mouse button will trigger the ability where you click.
This'll disable the context menu when pressing right click if the ability is active, but you can hold shift before right clicking to re-enable the context menu if you need it for some specific purpose without having to deactivate the ability or switch your preferences.
Explain why it's good for the game
Right mouse button is just a lot more convenient for me and I'm sure this'll be useful for other players too. This is primarily a quality of life change, the preference to use the middle mouse button or the left mouse button with shift click will still exist.
It's a big problem for me since the middle mouse button on my mouse is somewhat faulty and doesn't always register clicks correctly. Shiftclick is also really awkward for me to use because I don't want to have to hold down multiple buttons to use my abilities. Adding a new option on the rmb makes sense here.
Testing Photographs and Procedure
Tested on my local and seems to work fine. You can rightclick normally when the ability is disabled or if you have the preference off, but rightclick to proc ability works fine.
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
qol: Adds a new preference option for activating xeno abilities: Right click. Prevents the context menu from opening whenever you have an ability active, and the ability can then be triggered with right click. Context menu can still be forced open by holding shift before right clicking, even if the ability is active.
/:cl: