Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PSDK-640): add networkId to WalletData #343

Open
wants to merge 1 commit into
base: v0.13.0
Choose a base branch
from
Open

Conversation

0xRAG
Copy link

@0xRAG 0xRAG commented Dec 17, 2024

What changed? Why?

It should be clear which saved wallets belong to which networks when you save_seed / export_data for a given wallet.

How i tested

After running:

const wallet = await Wallet.create({
  networkId: Coinbase.networks.BaseSepolia,
});

wallet.saveSeed("/Users/ryan/code/public/seeds/wallet_seed.json");

wallet_seed.json looks like:

{
  "f737686d-c78f-4b89-9bf4-7b57559425b8": {
    "seed": "8a5xxx",
    "encrypted": false,
    "authTag": "",
    "iv": "",
    "networkId": "base-sepolia"
  }
}

And the result of wallet.export():

{
  walletId: 'f737686d-c78f-4b89-9bf4-7b57559425b8',
  seed: '8a5xxx',
  networkId: 'base-sepolia'
}

Qualified Impact

The network id should always be present, and if it is not, it will simply not be included in the WalletData

@cb-heimdall
Copy link

cb-heimdall commented Dec 17, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xRAG 0xRAG force-pushed the PSDK-640 branch 4 times, most recently from 903b867 to 56537bb Compare December 17, 2024 21:44
@0xRAG 0xRAG changed the title chore: add networkId to WalletData chore(PSDK-640): add networkId to WalletData Dec 17, 2024
@0xRAG 0xRAG marked this pull request as ready for review December 17, 2024 22:08
@0xRAG 0xRAG changed the base branch from master to v0.13.0 December 17, 2024 22:16
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants