-
Notifications
You must be signed in to change notification settings - Fork 10.4k
raylib screenshots: fix pair device screenshot #36393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raylib screenshots: fix pair device screenshot #36393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fix navigation for the "pair device" raylib screenshot flow so the screenshot can be captured deterministically.
- Open Settings before attempting to navigate to the Pair Device screen.
- Update the click target to new coordinates presumably corresponding to the Pair Device entry.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
why doesn't anything change? |
Because the pair device screenshot is purposely excluded from the diff check in the workflow. But you can confirm by checking the artifacts that are uploaded, and I tried to make it included in the list still but only excluded from the diff check, but I couldn't make it work. |
|
I've now included a link to the artifacts file for confirmation |
|
Hold up, did this get fixed somehow without this? |
|
There's two buttons that can open the pairing dialog. |



















































We should also include it in the list of images in the PR, but only exclude from the diff check (since the QR code isn't repeatable)
Here's the artifacts branch for this PR for confirmation:
https://github.com/commaai/ci-artifacts/blob/openpilot/pr-36393-raylib-ui/pair_device.png
And from a recent PR:
https://github.com/commaai/ci-artifacts/blob/openpilot/pr-36439-raylib-ui/pair_device.png
...ok now it's working? 🤔