Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unstamped cmd_vel option is removed #903

Merged
merged 3 commits into from
Feb 26, 2024
Merged

unstamped cmd_vel option is removed #903

merged 3 commits into from
Feb 26, 2024

Conversation

skpawar1305
Copy link
Contributor

@skpawar1305 skpawar1305 commented Feb 26, 2024 •
edited
Loading

ros-controls/ros2_controllers#812

Affected Packages
List of affected packages:

  • webots_ros2_epuck
  • webots_ros2_tiago
  • webots_ros2_turtlebot

Tasks
Add the list of tasks of this PR.

  • Pass ROS2 Rolling tests

@skpawar1305 skpawar1305 force-pushed the skpawar1305/fix_rolling_tests branch 3 times, most recently from fe7905b to 323b488 Compare February 26, 2024 12:47
@skpawar1305 skpawar1305 marked this pull request as draft February 26, 2024 12:55
@skpawar1305 skpawar1305 force-pushed the skpawar1305/fix_rolling_tests branch from 323b488 to b1db544 Compare February 26, 2024 13:08
@skpawar1305 skpawar1305 force-pushed the skpawar1305/fix_rolling_tests branch from c33e9c8 to b7b6d7d Compare February 26, 2024 14:40
@skpawar1305
don't enable twist stamped cmd_vel yet
f2bef4e 
as nav2 packages are not available for rolling
@skpawar1305 skpawar1305 force-pushed the skpawar1305/fix_rolling_tests branch from 693e9cc to f2bef4e Compare February 26, 2024 14:53
@skpawar1305 skpawar1305 marked this pull request as ready for review February 26, 2024 15:39
@skpawar1305 skpawar1305 self-assigned this Feb 26, 2024
@skpawar1305 skpawar1305 requested review from BenjaminHug8, omichel and ygoumaz and removed request for BenjaminHug8 February 26, 2024 17:16
omichel
omichel approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@omichel omichel merged commit 7b0e501 into master Feb 26, 2024
7 checks passed
@omichel omichel deleted the skpawar1305/fix_rolling_tests branch February 26, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

@ygoumaz ygoumaz Awaiting requested review from ygoumaz

Assignees

@skpawar1305 skpawar1305

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skpawar1305 @omichel