Show on App Launch: Translations #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
6 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
dc43c2e to
3ac59e0
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
3ac59e0 to
895f987
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
895f987 to
f817cbc
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
from
9e17bc5 to
2255144
Compare
55 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
f817cbc to
77c276d
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
from
2255144 to
4b18eac
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
4525020 to
9b57b79
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
2 times, most recently
from
6a40fe1 to
9b0bfe9
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
16e96ff to
2bab6af
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
2 times, most recently
from
cbfa50f to
bd1e9f5
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
0958ef2 to
4c2ffe1
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
from
bd1e9f5 to
4dba6e6
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
4c2ffe1 to
e6fc998
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
from
4dba6e6 to
f22a708
Compare
12 tasks
Translate strings to values-fr
Translate strings to values-cs
Translate strings to values-sv
Translate strings to values-sk
Translate strings to values-el Translate strings to values-it
Translate strings to values-es Translate strings to values-ro Translate strings to values-tr Translate strings to values-sk Translate strings to values-ru Translate strings to values-et Translate strings to values-it Translate strings to values-pl Translate strings to values-bg Translate strings to values-lv Translate strings to values-fi Translate strings to values-sl Translate strings to values-nl Translate strings to values-hr Translate strings to values-hu Translate strings to values-nb Translate strings to values-sv Translate strings to values-da Translate strings to values-el Translate strings to values-fr Translate strings to values-lt Translate strings to values-pt Translate strings to values-cs
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-persistence
branch
from
e6fc998 to
c3e9c87
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/translations_l10n
branch
from
f22a708 to
b40783d
Compare
Translate strings to values-es Translate strings to values-ro Translate strings to values-tr Translate strings to values-sk Translate strings to values-ru Translate strings to values-et Translate strings to values-it Translate strings to values-pl Translate strings to values-bg Translate strings to values-lv Translate strings to values-fi Translate strings to values-sl Translate strings to values-nl Translate strings to values-hr Translate strings to values-hu Translate strings to values-nb Translate strings to values-sv Translate strings to values-da Translate strings to values-el Translate strings to values-fr Translate strings to values-lt Translate strings to values-pt Translate strings to values-cs
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208167186867417/f ### Description Adds functionality to open the show on app launch option based on what has been set. If there is no specialised launch happening then we check the show on app launch setting: 1. If LastOpenedTab is set, we do nothing as this is current behaviour 2. If NewTabPage is set then we open a new tab 3. If SpecificPage is set we compare the url to the current selected tab, if it's not the same we open a new tab otherwise we do nothing Also as part of this PR, we add validation to the URL: 1. It is blank will set it as a default to duckduckgo.com 2. If it has no scheme will add http (in case the website does not currently support https) 3. Otherwise return the url what was passed in ### Steps to test this PR _Last Opened Tab_ - [x] Set "Show on App Launch" to **Last Opened Tab** - [x] Exit Settings - [x] Remember your current tab and tab count - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is the same as when you closed - [x] Ensure the tab count has not increased _New Tab Page_ - [x] Set "Show on App Launch" to **New Tab Page** - [x] Exit Settings - [x] Remember your current tab and tab count. If this is the **New Tab Page** then please open a website e.g. “bbc.com" - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is now the **New Tab Page** - [x] Ensure the tab count **has** increased by one - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is still the **New Tab Page** - [x] Ensure the tab count has **not** increased by one _Specific Page_ - [x] Set "Show on App Launch" to **Specific Page** - [x] Check the default URL is “https://duckduckgo.com/” - [x] Exit Settings - [x] Remember your current tab (it should not be “https://duckduckgo.com/”) and tab count - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is now **https://duckduckgo.com/** - [x] Ensure the tab count **has** increased by one (if your tab was on the new tab page before you force closed it would not increase) - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is still **https://duckduckgo.com/** - [ ] Ensure the tab count has **not** increased by one _Specific Page Lowercasing_ - [x] Set "Show on App Launch" to **Specific Page** - [x] Change the default URL to “BBC.com” - [x] Press back - [x] Check that under the "Show on App Launch” setting the url is “http://bbc.com” _Specific Page Updated_ - [x] Set "Show on App Launch" to **Specific Page** - [x] Change the default URL to a different url e.g. “cnn.com" - [x] Exit Settings - [x] Remember your current tab (it should **not** be the same url you entered earlier) and tab count - [x] Force close the app via recents - [x] Open the app - [x] Check the tab is now the url you set e.g. **cnn.com** - [x] Ensure the tab count **has** increased by one _Specific Page Not a URL_ - [x] Set "Show on App Launch" to **Specific Page** - [x] Change the default URL to a url that is invalid e.g. “example" - [x] Press back - [x] Check that under the "Show on App Launch” setting the url is “http://example” - [x] Remember your current tab (it should **not** be the same url you entered earlier) and tab count - [x] Force close the app via recents - [x] Open the app - [x] Check the tab has attempted to load "http://example" - [x] Ensure the tab count **has** increased by one _Specific Page Different Scheme_ - [x] Set "Show on App Launch" to **Specific Page** - [x] Change the default URL to a url with a different scheme e.g. “ftp://file.com" - [x] Press back - [x] Check that under the "Show on App Launch” setting the url is still “ftp://file.com” ### UI changes N/A ### Demo https://github.com/user-attachments/assets/6296bd2e-d083-46fd-a738-787e8bf2b6ee
mikescamell
merged commit 2e3acfe
into
feature/mike/show-on-app-launch/add-persistence
4 of 5 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/translations_l10n
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709092/f
Description
Translations for Show on App Launch
Steps to test this PR
N/A
UI changes
No UI changes