Show on App Launch: Add additional tests #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
55 tasks
anikiki
approved these changes
Sep 11, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
7959fa4 to
b7df6fb
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
040c51b to
48daa7f
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
b7df6fb to
8a4f4c6
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
ccc2541 to
b595ff5
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
8a4f4c6 to
fd687fc
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
b595ff5 to
2ece0f5
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
fd687fc to
9e45cbc
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
2 times, most recently
from
a9c2dc8 to
5999f49
Compare
anikiki
approved these changes
Sep 12, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
9e45cbc to
39ba200
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
5999f49 to
abf5f3d
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
39ba200 to
bf33919
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
509da97 to
4c6b0e2
Compare
12 tasks
technically this can obviously be anything but I'd rather use the default we agreed on in the tests too. The ShowOnAppLaunchPrefsDataStoreTest covers whether the default url is correct or not
we updated the default url to "https://duckduckgo.com/" so the test needs updating
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/open-launch-option-when-set
branch
from
bf33919 to
606fe1c
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
4c6b0e2 to
466de55
Compare
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709090/f ### Description Adds three pixels to the Show on App Launch feature: - When the Show on App Launch screen is opened from General settings (temporary pixel) - When selecting a new Show on App Launch option (temporary pixel) - When the daily pixel is fired (permanent pixel) ### Steps to test this PR _App launch pressed pixel_ - [x] Go to general settings screen - [x] Click “Show on App Launch" - [x] Checks logs to if `m_settings_general_app_launch_pressed` is sent _New option selected pixel_ - [x] Go to Show on App Launch screen - [x] Click “New Tab Page” - [x] Check logs for `m_settings_general_app_launch_new_tab_page_selected` pixel - [x] Click “Specific Page" - [x] Check logs for `m_settings_general_app_launch_specific_page_selected` pixel - [x] Click “Last Opened Tab” - [x] Check logs for `m_settings_general_app_launch_last_opened_tab_selected` pixel _Daily pixel_ - [x] Launch app - [x] Check daily pixel for “launch_screen” and check it’s the same as what you have selected for “Show on App Launch" ### UI changes N/A
mikescamell
merged commit 621d02e
into
feature/mike/show-on-app-launch/open-launch-option-when-set
4 of 5 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/add-more-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709083/f
Description
Adds some additional tests for the BrowserViewModel and the ShowOnAppLaunch store
Steps to test this PR
N/A
UI changes
N/A