-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show on App Launch: Add pixels #5040
Merged
mikescamell
merged 4 commits into
feature/mike/show-on-app-launch/add-more-tests
from
feature/mike/show-on-app-launch/add-pixels
Sep 20, 2024
Merged
Show on App Launch: Add pixels #5040
mikescamell
merged 4 commits into
feature/mike/show-on-app-launch/add-more-tests
from
feature/mike/show-on-app-launch/add-pixels
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on Graphite |
seeing as this is the only place I want to synchronously get the show on app launch option I chose to runBlocking when getting the setting here rather than adding a function to the DataStore
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-more-tests
branch
from
September 19, 2024 14:48
4c6b0e2
to
466de55
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/add-pixels
branch
from
September 19, 2024 14:48
6ed635a
to
ee7c723
Compare
anikiki
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected 🎉
mikescamell
merged commit Sep 20, 2024
73e37be
into
feature/mike/show-on-app-launch/add-more-tests
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709090/f
Description
Adds three pixels to the Show on App Launch feature:
Steps to test this PR
App launch pressed pixel
m_settings_general_app_launch_pressed
is sentNew option selected pixel
m_settings_general_app_launch_new_tab_page_selected
pixelm_settings_general_app_launch_specific_page_selected
pixelm_settings_general_app_launch_last_opened_tab_selected
pixelDaily pixel
UI changes
N/A